o/snapstate: prevent removal of seed-refresh snaps when seed-refresh is enabled - #16952
Merged
andrewphelpsj merged 1 commit intoJun 1, 2026
Merged
Conversation
github-actions
Bot
added
the
Needs Documentation -auto-
|
Mon Jun 1 14:13:32 UTC 2026 Failures:Executing:
Skipped tests from snapd-testing-skipIf you wish to have any of the below tests run in your PR, in your PR description, add 'unskip:' followed by a copy-and-pasted list (without variants) of the below tests you wish to run (unskip plus test list must be valid yaml)
|
andrewphelpsj
force-pushed
the
seed-refresh-prevent-remove
branch
2 times, most recently
from
April 23, 2026 14:01
97e87f7 to
30bea64
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #16952 +/- ##
==========================================
- Coverage 78.99% 78.99% -0.01%
==========================================
Files 1378 1376 -2
Lines 192017 192101 +84
Branches 2464 2464
==========================================
+ Hits 151681 151743 +62
- Misses 31185 31207 +22
Partials 9151 9151
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
andrewphelpsj
force-pushed
the
seed-refresh-prevent-remove
branch
2 times, most recently
from
April 29, 2026 16:41
3bfd63f to
4a527b7
Compare
github-actions
Bot
removed
the
Needs Documentation -auto-
andrewphelpsj
force-pushed
the
seed-refresh-prevent-remove
branch
from
May 6, 2026 18:53
4a527b7 to
7f2902d
Compare
andrewphelpsj
force-pushed
the
seed-refresh-prevent-remove
branch
2 times, most recently
from
May 28, 2026 15:28
9864a78 to
842a4f9
Compare
andrewphelpsj
commented
May 28, 2026
| // | ||
| // TODO:SEEDREFRESH: remove this hook once seed-refresh supports seeds | ||
| // gaining/losing snaps | ||
| var CheckSeedRefreshRemove = func(st *state.State, si *snap.Info, dctx DeviceContext) error { |
Member
Author
There was a problem hiding this comment.
Adding this does feel lame, but at least it is temporary?
andrewphelpsj
force-pushed
the
seed-refresh-prevent-remove
branch
from
May 29, 2026 13:38
842a4f9 to
b126617
Compare
andrewphelpsj
added
the
Auto rerun spread
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since seed-refresh doesn't support adding/losing snaps from the seed, we need to ensure that the running system always has the snaps that are a part of the seed.